feat: statefulsets, daemonsets, jobs and volumes implementation in k8s infra monitoring #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-nodes
branch
5 times, most recently
from
b5d57e1 to
ba944d0
Compare
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-nodes
branch
from
186f768 to
6d441f3
Compare
Base automatically changed from
feat/infra-monitoring-k8s-nodes
to
feat/infra-monitoring-k8s
January 3, 2025 06:09
amlannandy
force-pushed
the
feat/infra-monitoring-k8s
branch
from
c89ffab to
79cae2d
Compare
YounixM
force-pushed
the
feat/infra-monitoring-k8s
branch
from
a294614 to
6855009
Compare
amlannandy
force-pushed
the
feat/infra-monitoring-k8s
branch
from
2edb730 to
579c7cb
Compare
YounixM
force-pushed
the
feat/infra-monitoring-k8s
branch
from
579c7cb to
22a33e3
Compare
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-jobs
branch
from
a9011ac to
152b1b9
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
amlannandy
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 152b1b9 in 2 minutes and 7 seconds
More details
- Looked at
4611lines of code in33files - Skipped
0files when reviewing. - Skipped posting
9drafted comments based on config settings.
1. frontend/src/api/infraMonitoring/getK8sJobsList.ts:70
- Draft comment:
Consider adding more robust error handling for network errors or unexpected responses to improve reliability. - Reason this comment was not posted:
Confidence changes required:50%
The functiongetK8sJobsListis used to fetch data, but the error handling is not robust. It should handle network errors or unexpected responses more gracefully.
2. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:301
- Draft comment:
Consider definingexpandedRowRenderoutside the component or usinguseCallbackto prevent unnecessary re-renders. - Reason this comment was not posted:
Confidence changes required:40%
TheexpandedRowRenderfunction is defined within theK8sJobsListcomponent, which could lead to unnecessary re-renders. It would be better to define it outside the component or useuseCallbackto memoize it.
3. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:222
- Draft comment:
EnsuresetCurrentPageandsetOrderByare included in the dependency array ofuseCallbackforhandleTableChange. - Reason this comment was not posted:
Confidence changes required:30%
ThehandleTableChangefunction is defined usinguseCallback, which is good for performance. However, it should includesetCurrentPageandsetOrderByin its dependency array to ensure it always has the latest references.
4. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:397
- Draft comment:
IncludesetGroupByandsetExpandedRowKeysin the dependency array ofuseCallbackforhandleGroupByChange. - Reason this comment was not posted:
Confidence changes required:30%
ThehandleGroupByChangefunction usesuseCallbackbut does not includesetGroupByandsetExpandedRowKeysin its dependency array. This could lead to stale closures.
5. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/Logs/JobLogsDetailedView.tsx:66
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Comment looked like it was already resolved.
6. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/Metrics/JobMetrics.tsx:100
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
7. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/Traces/JobTraces.tsx:165
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
8. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:304
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
9. frontend/src/container/InfraMonitoringK8s/Jobs/utils.tsx:274
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_FuMuXRAIAnmIM4cN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
amlannandy
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
|
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-jobs
branch
from
8db8062 to
5ca6a1f
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 41281c9 in 52 seconds
More details
- Looked at
1667lines of code in2files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/constants.ts:657
- Draft comment:
The 'disabled' property is set to 'true' for this query data. Ensure this is intentional. This is also applicable at lines 700, 743, 832, 875, 918, 1525, and 1568. - Reason this comment was not posted:
Confidence changes required:50%
The code contains multiple instances where the 'disabled' property is set to 'true' for query data. This might be intentional, but it's worth pointing out in case it's an oversight.
2. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/constants.ts:102
- Draft comment:
The 'reduceTo' property is set to 'avg'. Ensure this is intentional. This is also applicable at lines 145, 188, 231, 273, 349, 393, 436, 479, 521, 564, 607, 859, 902, 945, 1028, 1127, 1220, 1313, 1389, 1432, 1475, 1551, and 1594. - Reason this comment was not posted:
Confidence changes required:50%
The code has multiple instances where the 'reduceTo' property is set to 'avg'. This might be intentional, but it's worth pointing out in case it's an oversight.
3. frontend/src/container/InfraMonitoringK8s/Nodes/NodeDetails/constants.ts:103
- Draft comment:
The 'spaceAggregation' property is set to 'sum'. Ensure this is intentional. This is also applicable at lines 146, 189, 232, 274, 350, 394, 437, 480, 522, 565, 608, 860, 903, 946, 1029, 1128, 1221, 1314, 1390, 1433, 1476, 1552, and 1595. - Reason this comment was not posted:
Confidence changes required:50%
The code has multiple instances where the 'spaceAggregation' property is set to 'sum'. This might be intentional, but it's worth pointing out in case it's an oversight.
4. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.tsx:107
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable to other imports in this file as well. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
5. frontend/src/container/InfraMonitoringK8s/InfraMonitoringK8s.tsx:359
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This is applicable to other imports in this file as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_ODM3Sqwi6pM1HKpa
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
amlannandy
force-pushed
the
feat/infra-monitoring-k8s-jobs
branch
from
6d17b16 to
4c1d8d7
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 6d17b16 in 1 minute and 27 seconds
More details
- Looked at
1109lines of code in12files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/StatefulSets/StatefulSetDetails/constants.ts:73
- Draft comment:
The import path forK8sStatefulSetsDataseems incorrect. It should beimport { K8sStatefulSetsData } from 'api/infraMonitoring/getK8sStatefulSetsList';instead ofgetsK8sStatefulSetsList. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
2. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/JobDetails.tsx:89
- Draft comment:
The filter keys inhandleChangeLogFiltersandhandleChangeTracesFiltersare incorrect. They should useQUERY_KEYS.K8S_JOB_NAMEinstead ofQUERY_KEYS.K8S_STATEFUL_SET_NAME. - Reason this comment was not posted:
Comment was on unchanged code.
3. frontend/src/container/InfraMonitoringK8s/DaemonSets/DaemonSetDetails/DaemonSetDetails.tsx:135
- Draft comment:
The value for thek8s.object.kindfilter should beDaemonSetinstead ofDaemonset. - Reason this comment was not posted:
Comment looked like it was already resolved.
4. frontend/src/container/InfraMonitoringK8s/StatefulSets/StatefulSetDetails/StatefulSetDetails.tsx:138
- Draft comment:
The value for thek8s.object.kindfilter should beStatefulSetinstead ofStatefulset. - Reason this comment was not posted:
Comment looked like it was already resolved.
5. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/JobDetails.tsx:414
- Draft comment:
Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This issue is also present in other files likeDaemonSetDetails.tsx,StatefulSetDetails.tsx, andVolumeDetails.tsx. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_siLDWTp7YDMAhgD1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
implements statefulsets, daemonsets, jobs and volumes entities in infra monitoring
Related Issues / PR's
N/A
Screenshots
Affected Areas and Manually Tested Areas
Infra Monitoring section
Important
Add support for monitoring statefulsets, daemonsets, jobs, and volumes in Kubernetes infrastructure, including API endpoints, UI components, and query hooks.
getK8sDaemonSetsList,getK8sJobsList,getK8sStatefulSetsList, andgetK8sVolumesListfunctions.K8sDaemonSetsList,K8sJobsList,K8sStatefulSetsList, andK8sVolumesListcomponents.DaemonSetDetails,JobDetails,StatefulSetDetails, andVolumeDetails.useGetK8sDaemonSetsList,useGetK8sJobsList,useGetK8sStatefulSetsList, anduseGetK8sVolumesListhooks.K8sCategoryandK8sEntityToAggregateAttributeMappingto include new entities.constants.ts.This description was created by
for 6d17b16. It will automatically update as commits are pushed.